jmackereth / eaglestuff

Tools for Analysing EAGLE simulations
0 stars 0 forks source link

2016feb ted #16

Closed jmackereth closed 8 years ago

jmackereth commented 8 years ago

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git

Samwalton9 commented 8 years ago

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University.

jmackereth commented 8 years ago

its doing the masses wrong again?

Or do you mean the component selection? you probably mean that.

On 17 Feb 2016, at 10:27, Sam Walton notifications@github.com wrote:

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

  • New memory usage reduction, object oriented mode etc.
  • Latest Version -- Ted
  • Brought my branch in line with mass cut changes

File Changes

  • M etools.pyhttps://github.com/jmackereth/eaglestuff/pull/16/files#diff-0 (332)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582.

Samwalton9 commented 8 years ago

The component selection!

On 17/02/16 10:29, Ted Mackereth wrote:

its doing the masses wrong again?

Or do you mean the component selection? you probably mean that.

On 17 Feb 2016, at 10:27, Sam Walton notifications@github.com wrote:

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

  • New memory usage reduction, object oriented mode etc.
  • Latest Version -- Ted
  • Brought my branch in line with mass cut changes

File Changes

  • M etools.pyhttps://github.com/jmackereth/eaglestuff/pull/16/files#diff-0 (332)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582.

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.uk

jmackereth commented 8 years ago

shall i merge that pull request then so your component masking gets added to that rather than the old version?

it should just merge without any problems when you’re done.

On 17 Feb 2016, at 10:30, Sam Walton notifications@github.com wrote:

The component selection!

On 17/02/16 10:29, Ted Mackereth wrote:

its doing the masses wrong again?

Or do you mean the component selection? you probably mean that.

On 17 Feb 2016, at 10:27, Sam Walton notifications@github.com wrote:

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

  • New memory usage reduction, object oriented mode etc.
  • Latest Version -- Ted
  • Brought my branch in line with mass cut changes

File Changes

  • M etools.pyhttps://github.com/jmackereth/eaglestuff/pull/16/files#diff-0 (332)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582.

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008.

Samwalton9 commented 8 years ago

Which pull request? From your 2016feb_ted branch?

On 17/02/16 10:38, Ted Mackereth wrote: shall i merge that pull request then so your component masking gets added to that rather than the old version?

it should just merge without any problems when you’re done.

On 17 Feb 2016, at 10:30, Sam Walton notifications@github.commailto:notifications@github.com wrote:

The component selection!

On 17/02/16 10:29, Ted Mackereth wrote:

its doing the masses wrong again?

Or do you mean the component selection? you probably mean that.

On 17 Feb 2016, at 10:27, Sam Walton notifications@github.commailto:notifications@github.com wrote:

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

  • New memory usage reduction, object oriented mode etc.
  • Latest Version -- Ted
  • Brought my branch in line with mass cut changes

File Changes

  • M etools.pyhttps://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0 (332)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582.

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008.

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185146564.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University.

jmackereth commented 8 years ago

Yes, but actually i think its best if i do another one when your new bits are on the master branch. so ignore that!

On 17 Feb 2016, at 10:39, Sam Walton notifications@github.com wrote:

Which pull request? From your 2016feb_ted branch?

On 17/02/16 10:38, Ted Mackereth wrote: shall i merge that pull request then so your component masking gets added to that rather than the old version?

it should just merge without any problems when you’re done.

On 17 Feb 2016, at 10:30, Sam Walton notifications@github.commailto:notifications@github.com wrote:

The component selection!

On 17/02/16 10:29, Ted Mackereth wrote:

its doing the masses wrong again?

Or do you mean the component selection? you probably mean that.

On 17 Feb 2016, at 10:27, Sam Walton notifications@github.commailto:notifications@github.com wrote:

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

  • New memory usage reduction, object oriented mode etc.
  • Latest Version -- Ted
  • Brought my branch in line with mass cut changes

File Changes

  • M etools.pyhttps://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0 (332)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582.

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008.

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185146564.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185147316.

Samwalton9 commented 8 years ago

Ok. My code is good to go, shall I merge it into master?

If you want to use it you need to do np.array([bool(i) for i in disc_mask]) on the hdf5 output because it saves as numbers (1s and 0s) rather than bools.

On 17/02/16 10:41, Ted Mackereth wrote:

Yes, but actually i think its best if i do another one when your new bits are on the master branch. so ignore that!

On 17 Feb 2016, at 10:39, Sam Walton notifications@github.com wrote:

Which pull request? From your 2016feb_ted branch?

On 17/02/16 10:38, Ted Mackereth wrote: shall i merge that pull request then so your component masking gets added to that rather than the old version?

it should just merge without any problems when you’re done.

On 17 Feb 2016, at 10:30, Sam Walton notifications@github.commailto:notifications@github.com wrote:

The component selection!

On 17/02/16 10:29, Ted Mackereth wrote:

its doing the masses wrong again?

Or do you mean the component selection? you probably mean that.

On 17 Feb 2016, at 10:27, Sam Walton notifications@github.commailto:notifications@github.com wrote:

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

  • New memory usage reduction, object oriented mode etc.
  • Latest Version -- Ted
  • Brought my branch in line with mass cut changes

File Changes

  • M

etools.pyhttps://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0 (332)

Patch Links:

— Reply to this email directly or view it on

GitHubhttps://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU

S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582.

— Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008.

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185146564.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185147316.

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185148477.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.uk

jmackereth commented 8 years ago

nice, yeah go ahead and do that!

right ok, ill add that into the loading routines!

cheers!

On 17 Feb 2016, at 10:47, Sam Walton notifications@github.com wrote:

Ok. My code is good to go, shall I merge it into master?

If you want to use it you need to do np.array([bool(i) for i in disc_mask]) on the hdf5 output because it saves as numbers (1s and 0s) rather than bools.

On 17/02/16 10:41, Ted Mackereth wrote:

Yes, but actually i think its best if i do another one when your new bits are on the master branch. so ignore that!

On 17 Feb 2016, at 10:39, Sam Walton notifications@github.com wrote:

Which pull request? From your 2016feb_ted branch?

On 17/02/16 10:38, Ted Mackereth wrote: shall i merge that pull request then so your component masking gets added to that rather than the old version?

it should just merge without any problems when you’re done.

On 17 Feb 2016, at 10:30, Sam Walton notifications@github.commailto:notifications@github.com wrote:

The component selection!

On 17/02/16 10:29, Ted Mackereth wrote:

its doing the masses wrong again?

Or do you mean the component selection? you probably mean that.

On 17 Feb 2016, at 10:27, Sam Walton notifications@github.commailto:notifications@github.com wrote:

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

  • New memory usage reduction, object oriented mode etc.
  • Latest Version -- Ted
  • Brought my branch in line with mass cut changes

File Changes

  • M

etools.pyhttps://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0 (332)

Patch Links:

— Reply to this email directly or view it on

GitHubhttps://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU

S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582.

— Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008.

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185146564.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185147316.

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185148477.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185149818.

Samwalton9 commented 8 years ago

Cool, done.

Oh, also, two things; what units is G in (line 309)? And I changed the jz_jcdisky to just be >0.7 as I mentioned the other day.

On 17/02/16 10:48, Ted Mackereth wrote: nice, yeah go ahead and do that!

right ok, ill add that into the loading routines!

cheers!

On 17 Feb 2016, at 10:47, Sam Walton notifications@github.commailto:notifications@github.com wrote:

Ok. My code is good to go, shall I merge it into master?

If you want to use it you need to do np.array([bool(i) for i in disc_mask]) on the hdf5 output because it saves as numbers (1s and 0s) rather than bools.

On 17/02/16 10:41, Ted Mackereth wrote:

Yes, but actually i think its best if i do another one when your new bits are on the master branch. so ignore that!

On 17 Feb 2016, at 10:39, Sam Walton notifications@github.commailto:notifications@github.com wrote:

Which pull request? From your 2016feb_ted branch?

On 17/02/16 10:38, Ted Mackereth wrote: shall i merge that pull request then so your component masking gets added to that rather than the old version?

it should just merge without any problems when you’re done.

On 17 Feb 2016, at 10:30, Sam Walton notifications@github.commailto:notifications@github.commailto:notifications@github.commailto:notifications@github.com wrote:

The component selection!

On 17/02/16 10:29, Ted Mackereth wrote:

its doing the masses wrong again?

Or do you mean the component selection? you probably mean that.

On 17 Feb 2016, at 10:27, Sam Walton notifications@github.commailto:notifications@github.commailto:notifications@github.commailto:notifications@github.com wrote:

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

  • New memory usage reduction, object oriented mode etc.
  • Latest Version -- Ted
  • Brought my branch in line with mass cut changes

File Changes

  • M

etools.pyhttps://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0 (332)

Patch Links:

— Reply to this email directly or view it on

GitHubhttps://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU

S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582.

— Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008.

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185146564https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185146564.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185147316https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185147316.

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185148477https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185148477.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185149818https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185149818.

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185150322.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University.

jmackereth commented 8 years ago

ive closed this request so i can open another.

so the G thing is a right nightmare, its G converted to the EAGLE units (but masses are converted to M_sun rather than 1e10M_sun at this point)

so its Mpc (M_sun)^-1 km^2 s^-2

ive triple checked this so I’m pretty sure its right, how come?

ah ok ill bear that in mind!!

Cheers!

On 17 Feb 2016, at 10:51, Sam Walton notifications@github.com wrote:

Cool, done.

Oh, also, two things; what units is G in (line 309)? And I changed the jz_jcdisky to just be >0.7 as I mentioned the other day.

On 17/02/16 10:48, Ted Mackereth wrote: nice, yeah go ahead and do that!

right ok, ill add that into the loading routines!

cheers!

On 17 Feb 2016, at 10:47, Sam Walton notifications@github.commailto:notifications@github.com wrote:

Ok. My code is good to go, shall I merge it into master?

If you want to use it you need to do np.array([bool(i) for i in disc_mask]) on the hdf5 output because it saves as numbers (1s and 0s) rather than bools.

On 17/02/16 10:41, Ted Mackereth wrote:

Yes, but actually i think its best if i do another one when your new bits are on the master branch. so ignore that!

On 17 Feb 2016, at 10:39, Sam Walton notifications@github.commailto:notifications@github.com wrote:

Which pull request? From your 2016feb_ted branch?

On 17/02/16 10:38, Ted Mackereth wrote: shall i merge that pull request then so your component masking gets added to that rather than the old version?

it should just merge without any problems when you’re done.

On 17 Feb 2016, at 10:30, Sam Walton notifications@github.commailto:notifications@github.commailto:notifications@github.commailto:notifications@github.com wrote:

The component selection!

On 17/02/16 10:29, Ted Mackereth wrote:

its doing the masses wrong again?

Or do you mean the component selection? you probably mean that.

On 17 Feb 2016, at 10:27, Sam Walton notifications@github.commailto:notifications@github.commailto:notifications@github.commailto:notifications@github.com wrote:

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

  • New memory usage reduction, object oriented mode etc.
  • Latest Version -- Ted
  • Brought my branch in line with mass cut changes

File Changes

  • M

etools.pyhttps://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0 (332)

Patch Links:

— Reply to this email directly or view it on

GitHubhttps://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU

S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582.

— Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008.

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185146564https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185146564.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185147316https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185147316.

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185148477https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185148477.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185149818https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185149818.

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185150322.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185151329.

Samwalton9 commented 8 years ago

Alright, I trust you! I just didn't recognise the form that it was in, can see why now :D

On 17/02/16 11:27, Ted Mackereth wrote:

ive closed this request so i can open another.

so the G thing is a right nightmare, its G converted to the EAGLE units (but masses are converted to M_sun rather than 1e10M_sun at this point)

so its Mpc (M_sun)^-1 km^2 s^-2

ive triple checked this so I’m pretty sure its right, how come?

ah ok ill bear that in mind!!

Cheers!

On 17 Feb 2016, at 10:51, Sam Walton notifications@github.com wrote:

Cool, done.

Oh, also, two things; what units is G in (line 309)? And I changed the jz_jcdisky to just be >0.7 as I mentioned the other day.

On 17/02/16 10:48, Ted Mackereth wrote: nice, yeah go ahead and do that!

right ok, ill add that into the loading routines!

cheers!

On 17 Feb 2016, at 10:47, Sam Walton notifications@github.commailto:notifications@github.com wrote:

Ok. My code is good to go, shall I merge it into master?

If you want to use it you need to do np.array([bool(i) for i in disc_mask]) on the hdf5 output because it saves as numbers (1s and 0s) rather than bools.

On 17/02/16 10:41, Ted Mackereth wrote:

Yes, but actually i think its best if i do another one when your new bits are on the master branch. so ignore that!

On 17 Feb 2016, at 10:39, Sam Walton notifications@github.commailto:notifications@github.com wrote:

Which pull request? From your 2016feb_ted branch?

On 17/02/16 10:38, Ted Mackereth wrote: shall i merge that pull request then so your component masking gets added to that rather than the old version?

it should just merge without any problems when you’re done.

On 17 Feb 2016, at 10:30, Sam Walton

notifications@github.commailto:notifications@github.commailto:notifications@github.commailto:notifications@github.com wrote:

The component selection!

On 17/02/16 10:29, Ted Mackereth wrote:

its doing the masses wrong again?

Or do you mean the component selection? you probably mean that.

On 17 Feb 2016, at 10:27, Sam Walton

notifications@github.commailto:notifications@github.commailto:notifications@github.commailto:notifications@github.com wrote:

Great!

I'm still figuring out whether the masking is working, because it doesn't seem to be right now, but when it is I'll push it up.

On 17/02/16 10:15, Ted Mackereth wrote:

Ive worked out what all those <<<<<<HEAD things mean haha

if you try to pull something thats got loads of changes those symbols mark out the major changes so you can correct them. I think i have now made it so your recent changes and mine are all consistent, so the new mass cut is there but also my snip shot stuff is treated correctly. The one thing i think now needs to be added/changed is the stuff you did yesterday to the saving etc.

Notice that the saving function has separate sections for snips and snaps now.

Hopefully this all works ok, its my fault for not keeping up with the git


You can view, comment on, or merge this pull request online at:

https://github.com/jmackereth/eaglestuff/pull/16

Commit Summary

  • New memory usage reduction, object oriented mode etc.
  • Latest Version -- Ted
  • Brought my branch in line with mass cut changes

File Changes

  • M

etools.pyhttps://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0https://github.com/jmackereth/eaglestuff/pull/16/files#diff-0

(332)

Patch Links:

— Reply to this email directly or view it on

GitHubhttps://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16https://github.com/jmackereth/eaglestuff/pull/16.

PhD Student Astrophysics Research Institute, LJMU

S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185141582.

— Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185142611.

PhD Student Astrophysics Research Institute, LJMU

S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185143008.

— Reply to this email directly or view it on

GitHubhttps://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185146564https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185146564.

PhD Student Astrophysics Research Institute, LJMU

S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185147316https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185147316.

— Reply to this email directly or view it on GitHub

https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185148477https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185148477.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185149818https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185149818.

— Reply to this email directly or view it on GitHubhttps://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185150322.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.ukmailto:S.R.Walton@2011.ljmu.ac.uk


Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. — Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185151329.

— Reply to this email directly or view it on GitHub https://github.com/jmackereth/eaglestuff/pull/16#issuecomment-185160855.

PhD Student Astrophysics Research Institute, LJMU S.R.Walton@2011.ljmu.ac.uk