search

jmakhack / myanimelist-cli

Minimalistic command line interface for fetching user anime data from MyAnimeList.
https://aur.archlinux.org/packages/mya-git
MIT License
11 stars 15 forks source link

[TASK] Fix unit testing issues for mya.c #29

Closed jmakhack closed 1 year ago

jmakhack commented 1 year ago

Task Context

The work to start adding unit tests to this project began in #13. A pull request was opened here: https://github.com/jmakhack/myanimelist-cli/pull/23

However, though a lot of work went into adding these unit tests, the work was never completed. There are currently issues with getting the tests to run and the project to build successfully.

This task is to work off the branch and code already present on that pull request and fix the issues so that:

  1. The project code can compile and build successfully
  2. The unit tests added can be successfully run
kana800 commented 1 year ago

Hello there ! I am interested in writing some unit tests; Let me know if this issue is available

jmakhack commented 1 year ago

Hey @kana800, you can work on this issue if you'd like! I've assigned it to you.

There currently isn't any unit testing framework set up so this task may be a bit tricky. Let me know if you need any help on this. There was some initial work done in #23 but was never completed.

kana800 commented 1 year ago

Hey @jmakhack I checked out the #23; There was some workdone by @TBeeren do you think he going to continue the #23? ;

jmakhack commented 1 year ago

@kana800, there have been some changes in the project code since then so no, but it is a good starting point/reference to work off of if needed.

jmakhack commented 1 year ago

Closing this for now and will potentially open a new issue for unit testing with updated details now that the build process for this project has changed.