jmakhack / myanimelist-cli

Minimalistic command line interface for fetching user anime data from MyAnimeList.
https://aur.archlinux.org/packages/mya-git
MIT License
11 stars 15 forks source link

Fixed code style issues in task template #36

Closed VividhPandey003 closed 1 year ago

VividhPandey003 commented 1 year ago

Signed-off-by: Vividh Pandey vividh.pandey.13@gmail.com

Associated Issue

image

Fixes the code style issue '[no-undefined-references] Found reference to undefined definition'

Closes #32

Implemented Solution

Removing the extra whitespace in line no 4 title: "[TASK] " solves the issue. This was done to improve the overall quality of the project files.

welcome[bot] commented 1 year ago

Thanks for opening this pull request for myanimelist-cli! Please wait shortly for someone to review. https://media1.tenor.com/images/de54dcf0d5723e5c190b36aed008917f/tenor.gif

ghost commented 1 year ago
πŸ‘‡ Click on the image for a new way to code review - Make big changes easier β€” review code in small groups of related files - Know where to start β€” see the whole change at a glance - Take a code tour β€” explore the change with an interactive tour - Make comments and review β€” all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=36&src=https%3A%2F%2Fgithub.com%2Fjmakhack%2Fmyanimelist-cli)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

jmakhack commented 1 year ago

Hey @VividhPandey003. Looks like there's also an issue with the code style checker so any fixes might not show up. See https://github.com/jmakhack/myanimelist-cli/pull/37#issuecomment-1264311965 where another programmer is having this issue.

I'll take a look into why the style checker is failing but in the meantime, I've marked your pull request as hacktoberfest-accepted. Thanks for looking into this! :)

jmakhack commented 1 year ago

@all-contributors please add @VividhPandey003 for maintenance

allcontributors[bot] commented 1 year ago

@jmakhack

I've put up a pull request to add @VividhPandey003! :tada:

VividhPandey003 commented 1 year ago

@jmakhack

I've put up a pull request to add @VividhPandey003! πŸŽ‰

Thank you @jmakhack. Really appreciate itπŸ˜„πŸ˜

jmakhack commented 1 year ago

Fixed the issue with Codacy not displaying the correct results.

If the issue is fixed, it should show up here: https://app.codacy.com/gh/jmakhack/myanimelist-cli/pullRequest?prid=10280332