jmakhack / myanimelist-cli

Minimalistic command line interface for fetching user anime data from MyAnimeList.
https://aur.archlinux.org/packages/mya-git
MIT License
11 stars 15 forks source link

Add missing file pattern to CODEOWNERS #47

Closed galbwe closed 1 year ago

galbwe commented 1 year ago

Associated Issue

closes #46

Implemented Solution

According to github's docs, the CODEOWNERS file should control who is automatically added as a PR reviewer.

The CODEOWNERS file is missing a filepath before the github username, which I think is the reason no reviewers are added automatically to PRs. You can verify by opening any file in this repo in the github ui. You should see a lock icon with hover text telling you the codeowner for that file

Screen Shot 2022-10-06 at 8 55 58 AM

Here is an example from a different repo where the CODEOWNERS file is correct:

Screen Shot 2022-10-06 at 8 57 37 AM

welcome[bot] commented 1 year ago

Thanks for opening this pull request for myanimelist-cli! Please wait shortly for someone to review. https://media1.tenor.com/images/de54dcf0d5723e5c190b36aed008917f/tenor.gif

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=47&src=https%3A%2F%2Fgithub.com%2Fjmakhack%2Fmyanimelist-cli)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

welcome[bot] commented 1 year ago

Congrats on merging your first pull request to myanimelist-cli! Please give our project a star if you like what we are building here. https://media1.tenor.com/images/7eaebbe5e4d63fc9b5f029d0bab363e3/tenor.gif