search

jmakhack / myanimelist-cli

Minimalistic command line interface for fetching user anime data from MyAnimeList.
https://aur.archlinux.org/packages/mya-git
MIT License
11 stars 15 forks source link

[BUG] Display more meaningful error message when Client ID not provided #51

Closed jmakhack closed 1 year ago

jmakhack commented 1 year ago

Bug Description

This project requires a MyAnimeList Client ID in order to fetch the required data from the API. https://github.com/jmakhack/myanimelist-cli/blob/61f91c22a837838b138ea0c35b8c947eda66b1aa/src/mya.c#L12

When the Client ID is not provided, the following misleading error is displayed:

Screen Shot 2022-10-08 at 6 52 14 PM

Expected Behavior

Instead of a User not found error message, the expected behavior is that a more meaningful error message would be displayed such as Client ID has not been provided.

Environment

Operating System: Ubuntu 22.04

Additional Context

Note: This issue is to only fix the issue where the Client ID has not been provided. A separate issue will be created to handle the case where an invalid Client ID has been provided.

For any questions or discussions, join the Discord to meet and engage with other contributors!

Discord

Sakshi-75 commented 1 year ago

Hi @jmakhack , Can I work on this?

jmakhack commented 1 year ago

Go for it @Sakshi-75!