jmakhack / myanimelist-cli

Minimalistic command line interface for fetching user anime data from MyAnimeList.
https://aur.archlinux.org/packages/mya-git
MIT License
11 stars 15 forks source link

[FEATURE] Improve Client ID setting experience #65

Closed jmakhack closed 1 year ago

jmakhack commented 1 year ago

Is your feature request related to a problem? Please describe

At the current moment, setting a MAL API Client ID within the source code is necessary in order to use this cli tool. This is unideal as users should not be expected to go into the source code and have to also build/compile the code.

Describe the solution you'd like

Multiple solutions can be explored to solve this issue.

One such solution would be to use an environment variable that the program uses to get the Client ID. This environment variable would be able to be set manually by the user or also via a command such as mya clientid <insert Client ID here>. Another solution could potentially involve having a separate config file and using something like libconfig.

Describe any possible alternatives

As stated above, there are many potential solutions to this issue and any alternatives that would make the user experience smoother and easier would be greatly appreciated. Feel free to start a discussion either here, on the discord, or by opening a draft pull request.

It may also be a good idea to see how other cli tools deal with this issue.

Additional context

Please read through the Contributing to the Project document before working on this project.

jmakhack commented 1 year ago

Closing as a duplicate of #99.