jmakhack / myanimelist-cli

Minimalistic command line interface for fetching user anime data from MyAnimeList.
https://aur.archlinux.org/packages/mya-git
MIT License
11 stars 15 forks source link

[TASK] Add check for buffer overflow when copying to destination (CWE-120) #68

Closed jmakhack closed 1 year ago

jmakhack commented 1 year ago

Task Context

The Codacy Static Code Analysis reports the following error in the codebase: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data.

More details can be found here: https://app.codacy.com/gh/jmakhack/myanimelist-cli/issues?bid=22863233&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6W119LHsiaWQiOiJDYXRlZ29yeSIsInZhbHVlcyI6WyJTZWN1cml0eSJdfSx7ImlkIjoiTGV2ZWwiLCJ2YWx1ZXMiOltdfSx7ImlkIjoiUGF0dGVybiIsInZhbHVlcyI6WyI2NTQ2Il19LHsiaWQiOiJBdXRob3IiLCJ2YWx1ZXMiOltdfV0=

Acceptance Criteria

The acceptance criteria for this task is to fix the issue mentioned in the Codacy link. After opening a pull request, the Codacy check will automatically run to see if the issue was fixed.

Additional Context

Please read through the Contributing to the Project document before working on this project.

For any questions or discussions, join the Discord to meet and engage with other contributors!

Discord