search

jmakhack / myanimelist-cli

Minimalistic command line interface for fetching user anime data from MyAnimeList.
https://aur.archlinux.org/packages/mya-git
MIT License
11 stars 15 forks source link

[TASK] Add bounds-checking interfaces #69

Closed jmakhack closed 1 year ago

jmakhack commented 1 year ago

Task Context

The Codacy Static Code Analysis reports the following error in the codebase: Use the bounds-checking interfaces for string manipulation.

More details can be found here: https://app.codacy.com/gh/jmakhack/myanimelist-cli/issues?bid=22863233&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6W119LHsiaWQiOiJDYXRlZ29yeSIsInZhbHVlcyI6WyJTZWN1cml0eSJdfSx7ImlkIjoiTGV2ZWwiLCJ2YWx1ZXMiOltdfSx7ImlkIjoiUGF0dGVybiIsInZhbHVlcyI6WyIxMzc2OSJdfSx7ImlkIjoiQXV0aG9yIiwidmFsdWVzIjpbXX1d

Acceptance Criteria

The acceptance criteria for this task is to fix the 4 issues mentioned in the Codacy link. After opening a pull request, the Codacy check will automatically run to see if the issue was fixed.

Additional Context

Please read through the Contributing to the Project document before working on this project.

For any questions or discussions, join the Discord to meet and engage with other contributors!

Discord

The-Debarghya commented 1 year ago

As this is quite related to #70 so I'm also trying to fix this