jmakhack / myanimelist-cli

Minimalistic command line interface for fetching user anime data from MyAnimeList.
https://aur.archlinux.org/packages/mya-git
MIT License
11 stars 15 forks source link

fix: make precedence of operators within expressions explicit #76

Closed metal-oopa closed 1 year ago

metal-oopa commented 1 year ago

Associated Issue

Closes #75

Implemented Solution

Added brackets to make the precedence of operators explicit.

if (username_len < MIN_USERNAME_LENGTH || username_len > MAX_USERNAME_LENGTH) to if ((username_len < MIN_USERNAME_LENGTH) || (username_len > MAX_USERNAME_LENGTH))

welcome[bot] commented 1 year ago

Thanks for opening this pull request for myanimelist-cli! Please wait shortly for someone to review. https://media1.tenor.com/images/de54dcf0d5723e5c190b36aed008917f/tenor.gif

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=76&src=https%3A%2F%2Fgithub.com%2Fjmakhack%2Fmyanimelist-cli)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

jmakhack commented 1 year ago

@all-contributors please add @metal-oopa for code

allcontributors[bot] commented 1 year ago

@jmakhack

I've put up a pull request to add @metal-oopa! :tada:

welcome[bot] commented 1 year ago

Congrats on merging your first pull request to myanimelist-cli! Please give our project a star if you like what we are building here. https://media1.tenor.com/images/7eaebbe5e4d63fc9b5f029d0bab363e3/tenor.gif