Security-Fix-70/69

[The-Debarghya]

Associated Issue

Closes #70 #69

Implemented Solution

• Replaced strcpy functions with strlcpy where the buffer value was kept as static string length and added BUFFER as a macro for strncpy(uri, json_object_get_string(next), BUFFER) this particular case.
• Replaced strcat functions with strncat where the max concat length was specified as static strings otherwise a macro MAX_ENDPOINT_LENGTH was used in this case: strncat(uri, endpoint, MAX_ENDPOINT_LENGTH); and for this case strncat(uri, username, MAX_USERNAME_LENGTH), a predefined macro MAX_USERNAME_LENGTH was used.

[welcome[bot]]

Thanks for opening this pull request for myanimelist-cli! Please wait shortly for someone to review.

[ghost]

👇 Click on the image for a new way to code review

- Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=77&src=https%3A%2F%2Fgithub.com%2Fjmakhack%2Fmyanimelist-cli)

Legend

[The-Debarghya]

I guess I forgot that I had to add libbsd as a dependency, I have added that to the workflow and the makefile.

[jmakhack]

@The-Debarghya Can you take a look at the following build error?

Run make all
gcc -c -g -Wall src/mya.c -o obj/mya.o
src/mya.c: In function ‘generate_endpoint’:
src/mya.c:253:3: error: a label can only be part of a statement and a declaration is not a statement
  253 |   const char* s = "completed";
      |   ^~~~~
make: *** [Makefile:41: obj/mya.o] Error 1
Error: Process completed with exit code 2.

Can you also leave a comment in #69 so I can assign that issue to you too :)

[The-Debarghya]

Can it be merged now?

[jmakhack]

@all-contributors please add @The-Debarghya for code

[allcontributors[bot]]

@jmakhack

I've put up a pull request to add @The-Debarghya! :tada:

[welcome[bot]]

Congrats on merging your first pull request to myanimelist-cli! Please give our project a star if you like what we are building here.