jmalcic / spina-admin-conferences

Conference management plugin for Spina.
MIT License
1 stars 1 forks source link

Switch to Turbo from Turbolinks #326

Closed jmalcic closed 3 years ago

jmalcic commented 3 years ago

This PR switches to Turbo from Turbolinks within the context of the engine. In practice this means that all links beginning with /admin/conferences have Turbolinks disabled, while Turbo is itself scoped to /admin/conferences. This means this gem will be able to use all of the cool new Turbo stuff while Spina can keep using Turbolinks. It was necessary to upgrade Trix as part of this change—there don't seem to be any compatibility problems but to some extent this is an unknown. Also there seems to be a concurrency bug with on-demand asset compilation in GitHub actions (not locally) so I've added a precompilation step to the workflow. This also means that if/when sassc segfaults we can see immediately.