search

jmaliksi / blaseball-mike

Totally not a microphone to the blaseball API
MIT License
14 stars 10 forks source link

Add Fool to Tarot in tables.py #129

Closed Qalthos closed 3 years ago

Qalthos commented 3 years ago

I am also open to removing INVALID and making _missing_ return FOOL, or removing both INVALID and _missing_ and considering the enum complete, a la StatType

I'm not sure if maintaining Tarot.INVALID is necessary, or if that was just added this way to support the (then presumably placeholder) values of the Coffee Cup teams. I'm also not even sure it's fair to say that a team like e.g. The Data Witches have the Fool as a tarot card, or even whether any of this will be relevant ever again with the current Reader v Coin happenings.

All that said, -1 is not an invalid value for the tarot attribute, all breach teams have -1 as their tarot value and the Fool as their card.

jmaliksi commented 3 years ago

This is technically a breaking change, will merge it with the other breaking changes in a sec