jmaliksi / blaseball-mike

Totally not a microphone to the blaseball API
MIT License
14 stars 10 forks source link

Gamma API changes #148

Open Edgarware opened 2 years ago

Edgarware commented 2 years ago

List of things that I know are 100% busted in the tests, will update as I find things (updated for Gamma 4)

brendonakay commented 2 years ago

I'd like to contribute to this project. Could I take on the Offseason/Chronicler item? I'm new and would need to ramp up on this project, so if it is time sensitive I will defer.

Edgarware commented 2 years ago

I'd like to contribute to this project. Could I take on the Offseason/Chronicler item? I'm new and would need to ramp up on this project, so if it is time sensitive I will defer.

Sure! I've got a draft pull request for it already for reference, but I'm not super happy with it right now.

brendonakay commented 2 years ago

@Edgarware I took a gander at your PR and it seems a little involved for me as a new-comer. Great work, by the way! Any suggestions for any of these other items? I'm also happy to help code review.

jmaliksi commented 2 years ago

@brendonakay I was going to define a new model for the new api.blaseball.com/bets/availableBets?day= endpoint sometime this week but if you want to take a gander at that, should be a good way to learn mike's design

@Edgarware what are we thinking as far as the stream events? should we pull in frostbird's thing or hold off until we have a better idea of TGB's plans?

brendonakay commented 2 years ago

This is excellent, thanks @jmaliksi! I will take a look at that this week.

Edgarware commented 2 years ago

@Edgarware what are we thinking as far as the stream events? should we pull in frostbird's thing or hold off until we have a better idea of TGB's plans?

@jmaliksi I'm fine bringing in frostbird's thing, I dont really anticipate them fixing the deltas before next Short Circuit and it'll be useful for people dealing with old data in the future.