jmalloc / ax

A message-driven application toolkit for Go. [EXPERIMENTAL]
MIT License
9 stars 3 forks source link

Separate application-defined mapping logic from the Saga itself. #112

Closed jmalloc closed 6 years ago

jmalloc commented 6 years ago

Fixes #111

There was no need that these methods be on the same value as the saga.Saga implementation. Decoupling them in this way allows for more flexible configuration, including the two new ByField() convenience functions:

codecov-io commented 6 years ago

Codecov Report

Merging #112 into master will decrease coverage by 0.1%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   30.17%   30.07%   -0.11%     
==========================================
  Files          65       65              
  Lines        2260     2268       +8     
==========================================
  Hits          682      682              
- Misses       1567     1575       +8     
  Partials       11       11
Impacted Files Coverage Δ
src/ax/saga/mapping/direct/mapper.go 0% <0%> (ø) :arrow_up:
src/ax/saga/mapping/keyset/byfield.go 0% <0%> (ø)
src/ax/saga/mapping/keyset/mapper.go 0% <0%> (ø) :arrow_up:
src/ax/aggregate/saga.go 0% <0%> (ø) :arrow_up:
src/ax/saga/mapping/direct/byfield.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 117dbcb...dd7e916. Read the comment docs.