search

jmalloc / ax

A message-driven application toolkit for Go. [EXPERIMENTAL]
MIT License
9 stars 3 forks source link

Change `MessageHandler` and `Saga` interfaces to accept a "message context". #141

Closed jmalloc closed 5 years ago

jmalloc commented 5 years ago

This replaces the separate sender and envelope parameters, and will grow in the future to accomodate other request-scoped values, such as the open-tracing span.

codecov-io commented 5 years ago

Codecov Report

Merging #141 into master will decrease coverage by 0.02%. The diff coverage is 36.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   30.55%   30.52%   -0.03%     
==========================================
  Files          72       72              
  Lines        2579     2578       -1     
==========================================
- Hits          788      787       -1     
  Misses       1767     1767              
  Partials       24       24
Impacted Files Coverage Δ
src/ax/saga/behavior.go 0% <0%> (ø) :arrow_up:
src/ax/saga/aggregate.go 0% <0%> (ø) :arrow_up:
src/ax/saga/workflow.go 0% <0%> (ø) :arrow_up:
src/ax/saga/handler.go 0% <0%> (ø) :arrow_up:
src/ax/routing/dispatcher.go 92.3% <100%> (+1%) :arrow_up:
src/ax/routing/handler.go 94.11% <100%> (-0.62%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb9420e...9f756cb. Read the comment docs.

jmalloc commented 5 years ago

Closing this, instead we'll retain the Sender as discussed. Work will continue on the add-message-context-2 branch.

jmalloc commented 5 years ago

Closing this, instead we'll retain the Sender as discussed. Work will continue on the add-message-context-2 branch.