jmalloc / ax

A message-driven application toolkit for Go. [EXPERIMENTAL]
MIT License
9 stars 3 forks source link

Add OpenTracing support to inbound and outbound pipelines. #151

Closed jmalloc closed 5 years ago

jmalloc commented 5 years ago

This is approaching done-ness. I just wanted to push the PR now to get some feedback, specifically on the "event" names used in all of the pipeline stages.

As best I can tell, the only outstanding feature is logging application-logs (those made through the MessageContext) to the span, which should be fairly trivial.

codecov-io commented 5 years ago

Codecov Report

Merging #151 into master will decrease coverage by 0.16%. The diff coverage is 27.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   28.42%   28.26%   -0.17%     
==========================================
  Files          76       78       +2     
  Lines        2744     3064     +320     
==========================================
+ Hits          780      866      +86     
- Misses       1941     2174     +233     
- Partials       23       24       +1
Impacted Files Coverage Δ
src/ax/endpoint/envelope.go 0% <ø> (ø) :arrow_up:
src/axrmq/transport.go 0% <0%> (ø) :arrow_up:
src/ax/endpoint/endpoint.go 0% <0%> (ø) :arrow_up:
src/ax/saga/persistence/crud/persister.go 0% <0%> (ø) :arrow_up:
src/ax/projection/consumer.go 0% <0%> (ø) :arrow_up:
src/ax/saga/handler.go 0% <0%> (ø) :arrow_up:
src/ax/endpoint/tracing.go 0% <0%> (ø)
src/axrmq/marshaling.go 0% <0%> (ø) :arrow_up:
src/ax/endpoint/receiver.go 0% <0%> (ø) :arrow_up:
src/ax/endpoint/transport.go 38.46% <0%> (-61.54%) :arrow_down:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc907c7...987858d. Read the comment docs.

jmalloc commented 5 years ago

Ah, I am also yet to add tracing through the saga subsystem.

jmalloc commented 5 years ago

This PR is now ready for a second round of review guys. All of the saga logging and appication-layer logging has been added now.

danilvpetrov commented 5 years ago

I can't see anything requiring changes.