search

jmalloc / ax

A message-driven application toolkit for Go. [EXPERIMENTAL]
MIT License
9 stars 3 forks source link

Add support for Dogma interfaces. #156

Closed jmalloc closed 5 years ago

jmalloc commented 5 years ago

/cc @danilvpetrov @koden-km

codecov-io commented 5 years ago

Codecov Report

Merging #156 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   28.26%   28.26%           
=======================================
  Files          78       78           
  Lines        3064     3064           
=======================================
  Hits          866      866           
  Misses       2174     2174           
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e19e58...03e0efb. Read the comment docs.

jmalloc commented 5 years ago

I think this is everything except for timeout support.

I'm probably going to need to make changes to Ax itself to support timeouts in the Dogma way, as timeouts are neither commands nor events, but Ax's nearest similar feature is the "delayed command" (and Dogma processes to not receive commands).

jmalloc commented 5 years ago

I wouldn't mind a "phase 1" review, even without timeouts. This one is probably more for you to look at and trial, Danil.