jmalloc / ax

A message-driven application toolkit for Go. [EXPERIMENTAL]
MIT License
9 stars 3 forks source link

Ensure all packages have a pkg.go and a ginkgo_test.go #75

Closed koden-km closed 6 years ago

koden-km commented 6 years ago

Fixes #26

codecov-io commented 6 years ago

Codecov Report

Merging #75 into master will decrease coverage by 10.52%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #75       +/-   ##
===========================================
- Coverage   45.71%   35.18%   -10.53%     
===========================================
  Files          38       50       +12     
  Lines        1387     1802      +415     
===========================================
  Hits          634      634               
- Misses        743     1158      +415     
  Partials       10       10
Impacted Files Coverage Δ
src/ax/saga/handler.go 0% <0%> (ø)
src/ax/saga/behavior.go 0% <0%> (ø)
src/ax/saga/mapping.go 0% <0%> (ø)
src/ax/outbox/deduplicator.go 0% <0%> (ø)
src/ax/saga/marshaling.go 0% <0%> (ø)
src/ax/saga/applier.go 0% <0%> (ø)
src/ax/saga/eventsourcing/recorder.go 0% <0%> (ø)
src/axcli/flags.go 0% <0%> (ø)
src/ax/saga/eventsourcing/persister.go 0% <0%> (ø)
src/axcli/command.go 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1471912...7ce0ebf. Read the comment docs.

jmalloc commented 6 years ago

Were there no missing pkg.go files?

koden-km commented 6 years ago

Sorry I guess I should have mentioned some details. Everything had a pkg.go except src/internal/, which none of them have. Also none of those have a ginkgo_test.go either, so I left internal as is. Everything else is done.

jmalloc commented 6 years ago

Ok, thanks. The internal ones (that aren't mocks) probably need them as well, but I plan to rearrange a little of that stuff anyway.