jmamma / MCL

MCL firmware for the MegaCommand MIDI Controller.
BSD 2-Clause "Simplified" License
53 stars 9 forks source link

fix ElektronPattern implementation virtual methods, fix SDDrive read #150

Closed yatli closed 3 years ago

jmamma commented 3 years ago

nuke

jmamma commented 3 years ago

machinedrum lockup on recv global :(

working now when i enabled debug.

let me try again for good luck.

yatli commented 3 years ago

I think we should add back MDGlobal()

yatli commented 3 years ago

This is the kind of dark corner in C++ -- if we don't provide ctor, but it's actually a derived class from ElektronSysexObject with virtual methods... the behavior is kinda undefined

jmamma commented 3 years ago

Okay, can you add constructors MDGlobal, MDPattern and MDKit ?

yatli commented 3 years ago

Processing. (You're doing declarative programming)

jmamma commented 3 years ago

Just did an empty reset and snap restore. looks good.

Side note:

I noticed from dumping Kit.name that the default MDKit's above 16 which appear as empty still had some data in them. Left over data from when elektron were creating the factory patches.

jmamma commented 3 years ago

Thanks. one more factory reset, snap then restore.

then we merge this one.

jmamma commented 3 years ago

then release 3.0.

then no more bug fixing for a long time.

yatli commented 3 years ago

then no more bug fixing for a long time.

Let's have some fun hacking new machines for MD instead!

jmamma commented 3 years ago

I'd like to make some music, oneday.

yatli commented 3 years ago

Yep, one day, and then get back to work :p :p :p

jmamma commented 3 years ago

restore was successful.

jmamma commented 3 years ago

closing this one.

yatli commented 3 years ago

Yep, one day, and then get back to work :p :p :p

Seriously, you should go enjoy what you've built.