jmamma / MCL

MCL firmware for the MegaCommand MIDI Controller.
BSD 2-Clause "Simplified" License
48 stars 9 forks source link

ringbuffer constexpr optimization #155

Closed yatli closed 3 years ago

yatli commented 3 years ago

consolidate put-put_h and get-get_h

Requires if constexpr from C++17.

yatli commented 3 years ago

End up with sysex error code 4 🤦‍♂️

jmamma commented 3 years ago

MDX_KIT_VERSION has changed to 0x64

jmamma commented 3 years ago

Ah hang on. I'm getting SYSEX ERROR 4 as well.

jmamma commented 3 years ago

eh sorry: c46d6d2d9acdccbb5df7c64132b0181112415e9b

yatli commented 3 years ago

ok after the merge it's good now