jmarchewka / apcupsd-pfsense-widget

A pfsense widget for the apcupsd daemon
MIT License
18 stars 2 forks source link

Constant configuration changes triggering Auto Configuration Backup #1

Closed Napsterbater closed 3 years ago

Napsterbater commented 3 years ago

This widget seems to cause "configuration changes" with the reason "Save apcupsd apcaccess results" seemingly every time it is loaded or refreshed on the dashboard.

This causes Auto Configuration Backup configured with "Automatically backup on every configuration change" to then backup the config every single time the widget is loaded or refreshed.

https://github.com/jmarchewka/apcupsd-pfsense-widget/blob/effc37b5ed0bc81d5a57135c7b98af3580cea6e9/apcupsd.widget.php#L40

jmarchewka commented 3 years ago

That's certainly not ideal. I fixed it with commit a0843b4.

Napsterbater commented 3 years ago

Looks to solve it, and the widget even loads faster. Win Win.