solarisfire commented 9 years ago

Running FTB Infinity v1.7.0 which is running Minecraft 1.7.10. Windows Server 2012 Standard.

nagios@nagios:/usr/lib/nagios/plugins# ./check_minecraft -H 192.168.2.86 -V 17 ERROR CHECKING MINECRAFT - , or ] expected while parsing array, at character offset 1019 (before "(end of string)") at ./check_minecraft line 229.

Looks to be a problem with the mod list not being returned with a valid JSON structure which causes the decode_json function to fail (seems to get cut short for some reason).

JSON returned from server:

{"description":"A Minecraft Server","players":{"max":10,"online":1,"sample":[{"id":"","name":""}]},"version":{"name":"1.7.10","protocol":5},"modinfo":{"type":"FML","modList":[{"modid":"mcp","version":"9.05"},{"modid":"FML","version":"7.10.99.99"},{"modid":"Forge","version":"10.13.4.1448"},{"modid":"appliedenergistics2-core","version":"rv2-stable-9"},{"modid":"Aroma1997Core","version":"1.0.2.13"},{"modid":"CodeChickenCore","version":"1.0.6.43"},{"modid":"InfiniBows","version":"1.3.0 build 20"},{"modid":"NotEnoughItems","version":"1.0.4.107"},{"modid":"ThaumicTinkerer-preloader","version":"0.1"},{"modid":"OpenModsCore","version":"0.7.3"},{"modid":"\u003cCoFH ASM\u003e","version":"000"},{"modid":"debug","version":"1.0"},{"modid":"act","version":"0.0.2a_1.7.10"},{"modid":"IC2","version":"2.2.726-experimental"},{"modid":"AdvancedSolarPanel","version":"1.7.10-3.5.1"},{"modid":"AgriCraft","version":"1.7.10-1.3.1"},{"modid":"appliedenergistics2","version":"rv2-stable-9"}

jmarler commented 9 years ago

Thanks for the report. I'll get a FTB Infinity server up and running and work on a patch. Have you made any changes to the stock config that might affect this I should be concerned about?

solarisfire commented 9 years ago

No changes to mod config.

Server config is:

Minecraft server properties

Mon Jul 27 16:39:59 BST 2015

generator-settings= op-permission-level=4 allow-nether=true level-name=world enable-query=true allow-flight=false announce-player-achievements=true server-port=25565 query.port=25565 level-type=DEFAULT enable-rcon=false force-gamemode=false level-seed= server-ip= max-build-height=256 spawn-npcs=true debug=false white-list=false spawn-animals=true hardcore=false snooper-enabled=false online-mode=true resource-pack= pvp=true difficulty=2 enable-command-block=false player-idle-timeout=0 gamemode=0 max-players=10 spawn-monsters=true view-distance=10 generate-structures=true spawn-protection=16 motd=A Minecraft Server

solarisfire commented 9 years ago

Actually it could be as simple as buffer length is too small.

$s->recv($buff,1024);

changed to

$s->recv($buff,2048);

and now it works.

solarisfire commented 9 years ago

That returns the full JSON object which can then be parsed by decode_json. Is having a limited size buffer the best way of doing this? It's going to break on even more heavily modded servers :-)

jmarler commented 9 years ago

The buffer should refill as needed, which is why it's in a loop. The way it is written, it pulls the first 1024 bytes, then loops again and grabs the next 1024 bytes. It should be able to handle any length of message that is returned, so I'm not quite sure what's happening here. I'll get a server setup and work on it. I may have to match the MTU of the OS.

jmarler / check_minecraft

Minecraft server reported down on heavily modified servers. #2

Minecraft server properties

Mon Jul 27 16:39:59 BST 2015