jmartinez95 / MI-449-SS17-741-js-conditionals-uMDt4P

0 stars 1 forks source link

Project Feedback #1

Open jmartinez95 opened 7 years ago

jmartinez95 commented 7 years ago

@stuartpearman Can you take a look at this? It's hosted here and meets the following criteria:

stuartpearman commented 7 years ago

Yesssssssssssss. This is great. I can't say enough good things about your code. It's so nicely formatted, everything has its own function, and your random integer helper is flexible and really makes some cool things possible in your game.

There are only two things I would add:

  1. When you pick up the machette, run left, and your odds are not greater than 3, you don't get a message, just a blank screen.
  2. When you pick up the bat and run, if the odds are not in your favor, it shows the same message as when you fight with the bat. At first I thought something was wrong with the game because the same thing happened if I fought or ran.

Such a nice job on this though, well done! Let me know when you've made changes.

jmartinez95 commented 7 years ago

@stuartpearman Thank you! Just fixed the two bugs you mentioned.

stuartpearman commented 7 years ago

Cool, looks great! :shipit: