jmarucha / FanControl.Liquidctl

Get access to the pump and temperature sensors of your AIO in FanControl
GNU General Public License v3.0
40 stars 17 forks source link

Better support X62, add fan control, combined duty control #18

Closed Koli0842 closed 1 year ago

Koli0842 commented 1 year ago

Before else, I'm sorry for the lack of code quality, I am not well versed in C#. The latest release didn't work for me, I was getting null reference on startup, after compiling it myself it came alive. I did miss Fan speed and control, and my device has no separate pump duty. I had to resort to some ugly and imperfect hacks, but it's good enough for my use. Feel free to commit over it or comment whether I should change something if we're looking to merge this.

KHVBui commented 1 year ago

You're awesome, finally I'm able to control my x62 fans and pump with Fan Control.

Yamagata-P commented 1 year ago

Hi, can someone help me using this? I'm a total newbiew to C# Dev, and have been trying to install this build for the last couple hours. So far I have cloned the git repository, installed Visual Studio, openned the project and added the Extensions paths. Then i've saved this, installed python 3.7, pip installed PyInstaller and LiquidCtl, donwloaded UPX. And has tried to run the build-liquidctl.sh script line-byline sing the downloaded UPX directory in the --upx-dir flag... but I utimately have got a: "script 'D:\Projects\Dev\liquidctl\liquidctl\cli.py' not found" error in cmd and am stuck there, because I cant find this file in any place and thus I canot build the liquidctl.dll plugin file to try on my FanCOntroll software :( i've also tried to just press "Rebuild solution" in visual Studio and use the generated .DLL but it still gives me the error when I open FanControllv144: "LiquidctlPlugin could not initialize or has no sensors." Thank you

Koli0842 commented 1 year ago

Hi @Yamagata-P I personally just used VS Code, but to be honest I am also new to C#, it was a bit of a pain to put it together. All I needed was the build-liquidctl.sh and a dotnet dev env. The fact that you was able to build the dll is great! Have you put liquidctl exe next to the dll? Just in case, I uploaded my plugins folder. Might be a cheap solution, but maybe it helps https://1drv.ms/u/s!AuWODjg0Ch3FgdMZ3We0HxgqnzhYhQ?e=4KUa8R

Yamagata-P commented 1 year ago

Hi @Yamagata-P I personally just used VS Code, but to be honest I am also new to C#, it was a bit of a pain to put it together. All I needed was the build-liquidctl.sh and a dotnet dev env. The fact that you was able to build the dll is great! Have you put liquidctl exe next to the dll? Just in case, I uploaded my plugins folder. Might be a cheap solution, but maybe it helps https://1drv.ms/u/s!AuWODjg0Ch3FgdMZ3We0HxgqnzhYhQ?e=4KUa8R

Thank you very much Koli, unfortunately it still gives me the error message: "LiquidctlPlugin could not initialize or has no sensors." Maybe I should try after reinstalling windows

Koli0842 commented 1 year ago

@Yamagata-P Do you perhaps have a log file in your FanControl folder? I did not add too much logging but exceptions should probably appear there, if you find it, you could attach it here, see if anything pops up. Also you can try manually using liquidctl from a command line using the exe I provided. "liquidctl --json status" should suffice, see if your device comes up there