Closed K4KDR closed 7 years ago
Thanks for this... it is really strange. It doesn't happen on my machine locally when I run it (macOS). I'll have to try running it on Windows to see if I can debug. The logic for identifying and decoding a packet is pretty simple so hopefully there's just a silly mistake in there somewhere. Glad that the DK3WN decoder is out there now too!
Posted a potential fix. Mike Rupprecht caught another issue that may relate to this (transposed values of 0xC0) but I'm still looking into that one.
Thanks for the update! Pulled the latest files & replayed previously recorded audio w/ good packets. Unfortunately, the app decoded & displayed values obviously out of the expected range. The window where the decoder was run from displayed the following; hope it helps!:
Traceback (most recent call last):
File "minxss_beacon_decoder.py", line 373, in run
self.target(*args, **kwargs)
File "minxss_beacon_decoder.py", line 143, in readPort
selectedTelemetryDictionary = minxssParser.parsePacket(bufferData)
File "/home/k4kdr/MinXSS_Beacon_Decoder/minxss_parser.py", line 35, in parsePacket
selectedTelemetryDictionary['FlightModel'] = self.decodeFlightModel(minxssPacket[51]) # [Unitless]
IndexError: bytearray index out of range
Ditto comment from another issue, just for completeness:
Try the release 2d2887f (corresponding to release 1.0.2-beta). All the bad decoding has almost certainly been due to KISS special characters, which are now handled.
Looks like the math is worked out properly now. Other issues still stand but this one can be closed.
It appears that there may be an issue with the math calculations or something similar w/ regard to the numerical telemetry values that are decoded. After several passes now with excellent reception, there may be one accurate decode but others of equal reception quality produce values that deviate significantly from expected values. Further, using the same reception, the decoder from DK3WN renders the telemetry within limits. (Of course, I don't KNOW that the values in the DK3WN decoder are correct, but only offer the comparison as an illustration to help) Finally, even though out of limits, the values in the linux decoder and Windows decoder will be exactly the same when processing the same downlink stream. (Screen shots below do NOT reflect the same packet)