search

jmaspons / osmapiR

An R interface to OpenStreetMap API for fetching and saving data from/to the OpenStreetMap database
https://jmaspons.github.io/osmapiR/
GNU General Public License v3.0
5 stars 3 forks source link

Set core.autocrlf on windows GHA #28

Closed nealrichardson closed 1 week ago

nealrichardson commented 1 week ago

I stumbled across https://github.com/nealrichardson/httptest2/blob/main/.github/workflows/R-CMD-check.yaml#L30-L32 just now and realized that could be the source of https://github.com/nealrichardson/httptest2/issues/42 for you--when git clones, it inserts CRLF on Windows by default. Let's see if this fixes things.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.87%. Comparing base (2ed94fb) to head (30784e2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ======================================= Coverage 92.87% 92.87% ======================================= Files 26 26 Lines 2160 2160 ======================================= Hits 2006 2006 Misses 154 154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nealrichardson commented 1 week ago

Great, seems that fix the failing tests :partying_face:

Thank you!

It would be good to document the trick somewhere in httptest2

Yeah, agreed