jmathai / elodie

An EXIF-based photo assistant, organizer and workflow automation tool.
https://bit.ly/introducing-elodie
Apache License 2.0
1.27k stars 139 forks source link

Final source and destination path should not be identical #259

Open navaneeth opened 6 years ago

navaneeth commented 6 years ago

I have imported some photos. (elodie.py is in PATH)

cd ~
elodie.py import --album-from-folder --destination ~/Pictures /tmp/my-album

As expected, this created the following structure.

~ tree ~/Pictures/2017
/Users/navaneethkn/Pictures/2017
└── November
    └── my-album
        └── 2017-11-18_07-26-16-nkn_3455_5085-super-heroes-stage.jpg

Now, I am trying to update location info into the file.

~ elodie.py update --location=Bangalore ~/Pictures/2017/November/my-album

This fails with the following error:

Final source and destination path should not be identical
{"source":"/Users/navaneethkn/Pictures/2017/November/my-album/2017-11-18_07-26-16-nkn_3455_5085-super-heroes-stage.jpg", "destination":"None"}
****** ERROR DETAILS ******
File
-----------------------------------------------------------------------------------------------------------
/Users/navaneethkn/Pictures/2017/November/my-album/2017-11-18_07-26-16-nkn_3455_5085-super-heroes-stage.jpg

****** SUMMARY ******
Metric      Count
--------  -------
Success         0
Error           1

When I look at the image, it has the location info added. But the command was showing it as a failure.

navaneeth commented 6 years ago

I went through the code. Looks like this is just a warning. Actual processing has happened

jmathai commented 6 years ago

It's a valid bug. The error is because despite the EXIF changes it does not change the destination folder because the album name trumps the location which in turn thinks the operation failed. It should not report an error. Since it returns before the end of the function there are lines of code which do not execute.

Thanks for reporting.

crishnakh commented 4 years ago

Hi, I'm having the same problem today. For example I want to rename the location folder and it show the same error.

./elodie.py update --location="Utrera, Sevilla" /Folder/Unkown location/

Final source and destination path should not be identical

crishnakh commented 4 years ago

Well, if you config MapQuest developer api, the error disappeared