search

jmathai / elodie

An EXIF-based photo assistant, organizer and workflow automation tool.
https://bit.ly/introducing-elodie
Apache License 2.0
1.25k stars 137 forks source link

Python 3.10 Compatibility #449

Open MusikPolice opened 1 year ago

MusikPolice commented 1 year ago

Conditional upgrade of future to v0.18.3 and tabulate to v0.9.0 if and only if python version is > v3.10. This fixes the error "ImportError: cannot import name 'Iterable' from 'collections' in Python" on Python 3.10 and higher.

Tested on Ubuntu 22.04.2 LTS:

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.2 LTS
Release:        22.04
Codename:       jammy

with python version 3.10.6 and pip version 22.0.2

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

coveralls commented 1 year ago

Coverage Status

Coverage: 90.61%. Remained the same when pulling 6e34643fd31ac57bfccc599047da9ca202f119eb on MusikPolice:musikpolice/python-3.10 into 76ad82303fcbf0e4ab421dbfbb39e4a4cc76aecc on jmathai:master.

jmathai commented 1 year ago

Thanks for submitting. Tests are only running on python 3.8 at the moment and supporting python3.10 is a mess atm (see gh-418).