Open Cedric-Boucher opened 1 year ago
The fail on ci/circleci is due to the printed output being changed in result.py
. This is expected behavior for this PR (Issue #460)
the solution to #460 was to clarify in the printed output when files are not imported due to being duplicates of already imported files, instead of referring to them as "errors"
I am working on updating the tests for my code, I'll need to create another PR when it's done.
I have noticed that my code does fail 4 tests, even after updating the tests. so I will figure that out now
oh I don't need to make a new PR apparently. cool.
Well as you can see I've updated the tests to the new formatting and fixed the minor issue that had caused 4 of them to fail
On this note:
We should really add some test cases to test the functionality of trying to import a file that has already been imported, to see if the duplicate count goes up
the test that has now failed (for whatever reason) has nothing to do with any code I have changed. Odd
I changed nothing and now the test passes. It seems that the failed test was a HTTPS call to that geolocation server. Annoying
Another note. Is there any documentation that needs to be updated with this "UI" change?
resolved: #457 resolved: #460