jmattheis / goverter

Generate type-safe Go converters by simply defining an interface
https://goverter.jmattheis.de/
MIT License
502 stars 47 forks source link

Why are generated files marked as executable? #128

Closed isinyaaa closed 8 months ago

isinyaaa commented 8 months ago

Have you read the project documentation?

Describe your question The executable bit is set high on every file/folder created by goverter. Why is that the case?

Source code I just ran the example on the getting-started guide.

image

Note: I also confirmed this behaviour on the latest version.

Errors Include errors that occur while you run goverter.

jmattheis commented 8 months ago

That's a bug. The generated file shouldn't be executable.

isinyaaa commented 8 months ago

thanks for the quick answer, I was browsing through the code and can patch it if you want

jmattheis commented 8 months ago

Ahh thanks, I've already created an PR for this (:. Would you like to test / review the changes? (https://github.com/jmattheis/goverter/pull/129)

jmattheis commented 8 months ago

Fixed in v1.3.2.