jmattheis
commented
5 months ago Good catch! Goverter uses the method signature to identify methods. While parsing the methods from the interface, the second method will override the first one, causing a missing method and not satisfying the interface.
This is mostly because of method re-usage. E.g. given this
// goverter:converter
type Converter interface {
Convert(Input) Output
Convert2(Input2) Output
ConvertNested(NestedInput) NestedOutput
}
type Input struct {
Name string
Nested NestedInput
}
type Input2 struct {
Name string
Nested NestedInput
}
type Output struct {
Name string
Nested NestedOutput
}
type NestedInput struct{ Value string }
type NestedOutput struct{ Value string }goverter will generate this code
func (c *ConverterImpl) Convert(source nestedstruct.Input) nestedstruct.Output {
var exampleOutput nestedstruct.Output
exampleOutput.Name = source.Name
exampleOutput.Nested = c.ConvertNested(source.Nested)
return exampleOutput
}
func (c *ConverterImpl) Convert2(source nestedstruct.Input2) nestedstruct.Output {
var exampleOutput nestedstruct.Output
exampleOutput.Name = source.Name
exampleOutput.Nested = c.ConvertNested(source.Nested)
return exampleOutput
}
func (c *ConverterImpl) ConvertNested(source nestedstruct.NestedInput) nestedstruct.NestedOutput {
var exampleNestedOutput nestedstruct.NestedOutput
exampleNestedOutput.Value = source.Value
return exampleNestedOutput
}The generated method ConvertNested is used by both conversion methods. When there would be two methods with the same signature similar to your example, then goverter doesn't know which method to use.
Supporting multiple root methods with the same signature can probably be done without too much effort and then goverter could error when the described ambiguity occurs to prevent unexpected behavior. Would this cover your use-case?
Along with #80 goverter need a kind of method flavoring, to have different versions of methods with the same signature and have a way to choose which methods should be used when doing nested conversions. These flavored methods could be used to chose between multiple methods when there is an ambiguity.
Your Wrapper generic looks like you want to copy values to an existing instance of a type. Do you think a "copy to" feature along the lines of this would be useful to you?
// goverter:ignore Id CreateTime LastUpdateTime Name
CopyTo(source *MyModel, target *MyModel) (error)Goverter would apply all non ignored properties from source to target.
isinyaaa
Have you read the project documentation?
Describe your question
I'm trying to create mapping functions for merging instances, so, e.g. I have a
and now, on the same converter instance, I'd like to have two separate methods for merging Update into Existing, and the other way around.
Now I notice that as soon as I have another method for wrapping a specific
Model(sayMyModel) one of them goes missing, so e.g. when specifying something likeI get an error that the goverter struct doesn't properly implement the interface.
Source code Provided above.
Errors