Closed sublee closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.53%. Comparing base (
b046455
) to head (efefb02
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for this nice project. goverter saves a lot of my time.
goverter v1.5.0 has introduced the
goverter:variables
conversion mode. In this mode,goverter:enum
turns off unexpectedly.goverter:enum
should be enabled by default by the documentation.I investigated the issue and guessed the reason for this problem. There are two default configurations
DefaultConfigInterface
andDefaultConfigVariables
which turn ongoverter:enum
.DefaultConfigInterface
is used for thegoverter:converter
mode as its name indicates, butDefaultConfigVariables
is not used for thegoverter:variables
mode.This patch enables
DefaultConfigVariables
for thegoverter:variables
mode to fix the problem. You can prove it byvar_enum.yml
test scenario I added. This scenario fails without this patch.Thank you.