Closed lampajr closed 9 months ago
Hey @jmattheis,
I gave this a shot, I hope it can help :slightly_smiling_face:
Open points:
init
as goverter setting, maybe we could use constructor
or any other idea?nil
, maybe we could thinkg about an additional setting not-override
(or whatever) to skip a field assignment if nil
in the source, wdyt? Obv I think this could be a followup issue if you think makes senseAttention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
13d3233
) 97.47% compared to head (6aa5d54
) 97.87%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@lampajr could you review the adjusted version?
@lampajr could you review the adjusted version?
I just fixed a leftover in the doc (init --> default), it looks really great!!
I tried it also locally in my use case, and it worked well :muscle:
Good catch, thanks!
Fixes https://github.com/jmattheis/goverter/issues/93
New feature: allow users to provide a custom
constructor
in order to initialize thetarget
obj.Usage:
Generated converter:
Tests:
Added some test scenarios under
/scenario
, all those matchingconstructor*.yml