jmattheis / goverter

Generate type-safe Go converters by simply defining an interface
https://goverter.jmattheis.de/
MIT License
487 stars 46 forks source link

fix: remove empty lines from errors #98

Closed jmattheis closed 9 months ago

jmattheis commented 9 months ago

Old:

Error while creating converter method:
    func (github.com/jmattheis/goverter/execution.Converter).Convert(source github.com/jmattheis/goverter/execution.Input) github.com/jmattheis/goverter/execution.Output

| github.com/jmattheis/goverter/execution.Input
|
|
|
|            | func github.com/jmattheis/goverter/execution.DefaultName() string
|            |
|            |           | string
|            |           |
source.     :DefaultName()
target.Score
|      |
|      |
|      |
|      |
|      |
|      | int
|
| github.com/jmattheis/goverter/execution.Output

Method return type mismatches with target: string != int

New:

Error while creating converter method:
    func (github.com/jmattheis/goverter/execution.Converter).Convert(source github.com/jmattheis/goverter/execution.Input) github.com/jmattheis/goverter/execution.Output

| github.com/jmattheis/goverter/execution.Input
|
|            | func github.com/jmattheis/goverter/execution.DefaultName() string
|            |
|            |           | string
|            |           |
source.     :DefaultName()
target.Score
|      |
|      | int
|
| github.com/jmattheis/goverter/execution.Output

Method return type mismatches with target: string != int
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e80558e) 97.87% compared to head (9da8ff7) 97.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #98 +/- ## ========================================== - Coverage 97.87% 97.87% -0.01% ========================================== Files 39 39 Lines 1693 1692 -1 ========================================== - Hits 1657 1656 -1 Misses 25 25 Partials 11 11 ``` | [Files](https://app.codecov.io/gh/jmattheis/goverter/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jannis+Mattheis) | Coverage Δ | | |---|---|---| | [builder/error.go](https://app.codecov.io/gh/jmattheis/goverter/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jannis+Mattheis#diff-YnVpbGRlci9lcnJvci5nbw==) | `96.00% <100.00%> (-0.08%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.