search

jmattingley23 / AppleSkinSpigot

A server-side implementation of the AppleSkin mod for Paper/Spigot servers
MIT License
26 stars 8 forks source link

Remove version dependence, use Bukkit Messenger #3

Closed 2008Choco closed 2 years ago

2008Choco commented 2 years ago

This PR simplifies the project significantly. Rather than relying on server internals, the plugin now relies on Bukkit API for the plugin messaging channels so that this works on any version of Minecraft in the past and future. These changes were tested on a Spigot 1.18.1 server but will work at least on a 1.17.1 server and any server before that where the Bukkit messaging API was introduced (roughly 2011).

All Maven modules were removed and replaced with a single project as the need for multiple modules is no longer necessary.

As an aside, I'm not super familiar with Mockito. I cannot guarantee if the test coverage is 100% and I cannot guarantee that the tests are accurate. I know however that they do compile and all pass in their current state.

2008Choco commented 2 years ago

This PR addresses and closes both #1 and #2 (assuming the latter has Java 16 installed).

This plugin could theoretically target Java 8 as well. There's no real reason for it to target 16, but presumably most servers are running Java 16 at this point anyways.

jmattingley23 commented 2 years ago

This is awesome, thanks for putting this together. I'll try to take a look at it in the next few days and hopefully get everything merged.