jmaver-plume / kafkajs-msk-iam-authentication-mechanism

MIT License
21 stars 26 forks source link

Don't add security token header if empty #4

Closed DazKins closed 2 years ago

DazKins commented 2 years ago

Hey @jmaver-plume ! Thanks for this library, it's been super helpful for us.

Just one quick suggested amendment: We found that this library doesn't work if you've chosen to go with non-temporary auth credentials as the code assumes a session token is present. Adding this null check on sessionToken allows just access key ID and secret access key credentials to be used, which is our use case.

jmaver-plume commented 2 years ago

@DazKins Thx.