search

jmazzi / crypt_keeper

Transparent ActiveRecord encryption
http://jmazzi.github.com/crypt_keeper/
MIT License
288 stars 99 forks source link

Revert "Adds GitHub Actions CI + fixes for Ruby 3.1" #196

Closed jmazzi closed 9 months ago

jmazzi commented 2 years ago

Reverts jmazzi/crypt_keeper#194

@nikz I had to revert this change because it broke multiple tests.

nikz commented 2 years ago

Hi @jmazzi - apologies for that, I will try to find some time to take a look.

Seems like the failure might be dependency version related? I think the 7.0.0 specification may be wrong on my part 🤦‍♂️ 

Bundler could not find compatible versions for gem "activerecord":
[29](https://github.com/jmazzi/crypt_keeper/runs/5682488922?check_suite_focus=true#step:5:29)
    In activerecord_5_2.gemfile:
[30](https://github.com/jmazzi/crypt_keeper/runs/5682488922?check_suite_focus=true#step:5:30)
      activerecord (~> 5.2.0)
[31](https://github.com/jmazzi/crypt_keeper/runs/5682488922?check_suite_focus=true#step:5:31)

[32](https://github.com/jmazzi/crypt_keeper/runs/5682488922?check_suite_focus=true#step:5:32)
      crypt_keeper was resolved to 2.3.0, which depends on
[33](https://github.com/jmazzi/crypt_keeper/runs/5682488922?check_suite_focus=true#step:5:33)
        activerecord (>= 4.2, ~> 7.0.0)
jmazzi commented 2 years ago

There was a merge conflict with the gem versions, I may have incorrectly resolved it. 

On March 24, 2022, GitHub Notifications @.***> wrote:

Hi @jmazzi https://github.com/jmazzi - apologies for that, I will try to find some time to take a look.

Seems like the failure might be dependency version related? I think the 7.0.0 specification may be wrong on my part 🤦‍♂️

Bundler could not find compatible versions for gem "activerecord": 29 In activerecord_5_2.gemfile: 30 activerecord (~> 5.2.0) 31 32 crypt_keeper was resolved to 2.3.0, which depends on 33 activerecord (>= 4.2, ~> 7.0.0)

— Reply to this email directly, view it on GitHub https://github.com/jmazzi/crypt_keeper/pull/196#issuecomment- 1078358008, or unsubscribe https://github.com/notifications/unsubscribe- auth/AAAARYNXFG4ZOHXYWT7RS3DVBTL73ANCNFSM5RSGDYJQ. You are receiving this because you were mentioned.Message ID: @.***>

nikz commented 2 years ago

Sweet, hopefully it's something with a straightforward resolve :) HTH, might just have to give me a bit.