search

jmb05 / caelum-refabricated

More realistic (and configurable) celestial bodies movement for Minecraft (Fabric)
MIT License
0 stars 2 forks source link

Solar eclipse #8

Open jmb05 opened 1 month ago

jmb05 commented 1 month ago

Make a solar eclipse possible when the moon comes close to the sun

BioTechproject27 commented 1 month ago

6

BioTechproject27 commented 1 month ago

Also I noticed the moon popping in and out of existance when it gets close to the sun (at least when using resource packs). Maybe this would be an opportunity to have solar eclipses?

So yea, I tested it without resourcepacks and that still happens. For example, on day 12 at ~15750t [e.g. using /time set 303600t will set the time to day 12, 15600t] the moon disappears as it gets close to the sun, and only appears 4 days later at day 16, ~21000t [/time set 404900t = 16d, 20900t] This example is usually only visible in skyblock where you can see the void, but it can obv happen on a normal day. This is just the very first instance it happens. A normal day would be the next instance it happens, being day 42 ~4500t [/time set 1012400t = 42d, 4400t], which is basically mid day when the moon just plops out of existance. Appearing again on day 46 ~9750t [/time set 1113600t = 46d, 9600t].

So yea, what I think happens is that the moon is simply not being displayed when the moon & sun textures intersect.

And I think this may be a perfect opportunity to add solar eclipses; Bcs a first idea would be that maybe the moon gets its texture intensity increased and the sun lowered as they approach, plus some darkening effects or sth.

jmb05 commented 1 month ago

The moon disappearing is deliberate. The moon is in the New Moon Phase and is not visible (in vanilla Minecraft the new moon is visible and I will add an option to make it visible).

BioTechproject27 commented 1 month ago

Yea, just saying that it should be visible (and in those specific circumstances it just looks weird)