search

jmbannon / ytdl-sub

Lightweight tool to automate downloading and metadata generation with yt-dlp
https://ytdl-sub.readthedocs.io
GNU General Public License v3.0
1.89k stars 71 forks source link

Docker labels are pointing to linuxserver not this repo #1115

Closed halkeye closed 3 weeks ago

halkeye commented 4 weeks ago 
regctl image config --format '{{ jsonPretty .Config.Labels }}' ghcr.io/jmbannon/ytdl-sub-gui:latest
{
  "build_version": "Linuxserver.io version:- 4.18.0-ls181 Build-date:- 2023-11-03T20:27:55+00:00",
  "maintainer": "aptalca",
  "org.opencontainers.image.authors": "linuxserver.io",
  "org.opencontainers.image.created": "2023-11-03T20:27:55+00:00",
  "org.opencontainers.image.description": "[Code-server](https://coder.com) is VS Code running on a remote server, accessible through the browser.  - Code on your Chromebook, tablet, and laptop with a consistent dev environment.  - If you have a Windows or Mac workstation, more easily develop for Linux.  - Take advantage of large cloud servers to speed up tests, compilations, downloads, and more.  - Preserve battery life when you're on the go.  - All intensive computation runs on your server.  - You're no longer running excess instances of Chrome.",
  "org.opencontainers.image.documentation": "https://docs.linuxserver.io/images/docker-code-server",
  "org.opencontainers.image.licenses": "GPL-3.0-only",
  "org.opencontainers.image.ref.name": "02a7bea1b8f8f4f97ed95799deea0de34a4064fa",
  "org.opencontainers.image.revision": "02a7bea1b8f8f4f97ed95799deea0de34a4064fa",
  "org.opencontainers.image.source": "https://github.com/linuxserver/docker-code-server",
  "org.opencontainers.image.title": "Code-server",
  "org.opencontainers.image.url": "https://github.com/linuxserver/docker-code-server/packages",
  "org.opencontainers.image.vendor": "linuxserver.io",
  "org.opencontainers.image.version": "4.18.0-ls181",
  "runnumber": "11604037552"
}

This leads to tools like renovate or dependabot trying to pull changelogs from the wrong place.

halkeye commented 4 weeks ago

I have a potential fix via https://github.com/docker/metadata-action but I'm not sure how to provide multiple cache-from urls to the action. How important/testable is it?

jmbannon commented 4 weeks ago

I have a potential fix via https://github.com/docker/metadata-action but I'm not sure how to provide multiple cache-from urls to the action. How important/testable is it?

We could alter the Github workflow to print the image metadata to test any change