Closed krafs closed 1 year ago
It's tricky because both match_filters
and date_range
share:
ytdl_options:
break_on_reject: true
Ideally they should have their own breaks - it's a yt-dlp limitation.
There is way to get around this issue though. What you can do is add the following:
match_filters:
filters:
- '!is_live'
ytdl_options:
break_on_reject: false
max_downloads: 100
This will
'!is_live'
)break_on_reject: false
)max_downloads: 100
)
a. If it's already downloaded, it won't be redownloaded because the TV show presets use a download archiveTry that and report back if it works :)
So, I've tried some stuff out:
I used max_downloads: 10
and break_on_reject: false
for testing, and it seems like a metadata item download only counts towards max_downloads
if the metadata download passes the date range check. Does that sound right? So ytdl-sub
will never reach max_downloads
because only the first few downloads that fall within the 2 week date range count. After that they stop counting, and it will just proceed with downloading all the metadata items (>300).
Removing the date range makes it work as expected - only 10 will be downloaded on the first go, and then only up until the last. However, this means I wouldn't be able to take advantage of the automatic removal of old videos, right?
Interesting! I think what you said is right - glad you found a work around. You can still use the auto deletion without date_range: https://ytdl-sub.readthedocs.io/en/latest/config.html#ytdl_sub.config.preset_options.OutputOptions.keep_files_before
You actually need to add it to your config as:
output_options:
keep_files_after: "today-2weeks"
I'm going to add this feature at some point which may also be a good alternative https://github.com/jmbannon/ytdl-sub/issues/672
I can certainly see a use case for a keep_max_entries
. Sounds like a good addition.
But yes - keep_files_after
seems to work the way I want for now. Perfect! Many thanks for the help, and good look on the project! I'll be following along :)
I am trying to download all live stream VODs from Linus Tech Tips from the last two weeks, but an old, always-active live stream gatekeeps them.
Basically: LTT has a continuous live stream that started July 6th. Live streams always appear at the top of the channel's Live playlist, regardless of start date.
ytdl-sub
downloads the metadata of the live stream, rejects it, because its start date is outside the two-week date range, and breaks. But there are plenty of live stream VODs that are within the two-week date range, but they come after the live stream in the playlist.Here is my setup, all located and executed from one and the same folder:
config.yaml
subscriptions.yaml
docker-compose.yaml
I am trying to have
ytdl-sub
ignore the live stream usingmatch_filters
, butytdl-sub
is still inspecting the date range of the video and breaking if outside the range, so it doesn't have the effect I'd hoped.Thoughts:
ytdl-sub
should work as normal.