search

jmbannon / ytdl-sub

Lightweight tool to automate downloading and metadata generation with yt-dlp
https://ytdl-sub.readthedocs.io
GNU General Public License v3.0
1.84k stars 71 forks source link

Unable to add a period/full stop in channel names #844

Closed tehseano closed 10 months ago

tehseano commented 10 months ago

Trying to set the name of a channel to include a period in the name, and I can't seem to get it to work. I have tried all the following:

"Mr. Beast":  "https://www.youtube.com/@MrBeast/videos"
"Mr\u002E Beast":  "https://www.youtube.com/@MrBeast/videos"
'Mr. Beast':  "https://www.youtube.com/@MrBeast/videos"
'Mr\. Beast':  "https://www.youtube.com/@MrBeast/videos"

They all return as:

[ytdl-sub] Beginning subscription dry run for Beast

And trying

"Mr\. Beast": "https://www.youtube.com/@MrBeast/videos"

Just crashes the script.

pharmacologic commented 10 months ago

I've noticed this too. If the period is partway in the channel name (i.e. J. Kenji López-Alt), it will take everything following the period (Kenji López-Alt) as the channel name, using that for the output folder and download archive filename etc.

If the period is at the end of the channel name, (i.e. let's talk about stuff.), the channel name is taken as empty, and the files / season folders end up in the main output folder.

Renaming the folders / moving files, plus editing the tvshow.nfo has worked as a temporary fix.

jmbannon commented 10 months ago

Bugfix is almost ready to be pushed @pharmacologic @tehseano , but FYI it requires renaming download archive files if you have any with a period in the subscription name (see the PR's description)

pharmacologic commented 10 months ago

My two channel subscriptions containing periods are still behaving oddly with this bugfix (ytdl-sub 2023.12.27+65bb5c0).

Subscription let's talk about stuff. is output to folder let's talk about stuff with download archive .ytdl-sub-let's talk about stuff-download-archive.json

J. Kenji López-Alt ends up with output folder J and download archive .ytdl-sub-J-download-archive.json

The tvshow.nfo is affected too, receiving series titles let's talk about stuff and J.

jmbannon commented 10 months ago

@pharmacologic

Can you run ytdl-sub --version ? Sounds like you may not be on latest

EDIT - didn't see you included it. Let me investigate

jmbannon commented 10 months ago

@pharmacologic You are right - still is a bug. Should actually be fixed and properly tested in this: https://github.com/jmbannon/ytdl-sub/pull/861

jmbannon commented 10 months ago

Should be fixed and pushed @pharmacologic - let me know otherwise (again :wink: )