search

jmbannon / ytdl-sub

Lightweight tool to automate downloading and metadata generation with yt-dlp
https://ytdl-sub.readthedocs.io
GNU General Public License v3.0
1.74k stars 69 forks source link

Update dependencies #961

Closed Noodlez1232 closed 5 months ago

Noodlez1232 commented 5 months ago

Making the dependencies hard on one version makes it much more difficult to package especially on distros like NixOS where in order to package it, the dependencies each need to be packaged as well in the case of this project. Perhaps it might be a good idea to instead of depending on specific versions, depend on their major (or major+minor) version numbers?

I also think moving to a pyproject.toml file wouldn't be a bad idea either, since this will allow the removal of the setup.cfg file.

Of course, I'm not just saying this and putting the burden on you, I'm willing to do this work. I am more gauging the interest in this.

I've already tested at least updating the PyYAML dependency and removing the argparse dependency (since it comes in the python stdlib), and it worked flawlessly. All drop-in.

jmbannon commented 5 months ago

This all sounds great! I've been meaning to move to a .toml but just haven't got around to it yet.

As for the deps, I'd be okay with setting it to the current major version so long as it's capped at that (minor versions should be okay to auto-upgrade).

A pull request would be greatly appreciated 😊