2015-Feb-03 Performance Improvements - Githubissues

jmbledsoe / angularjs-visualstudio-intellisense

Visual Studio extension providing statement completion for injected AngularJS components in JavaScript files.

MIT License

110 stars 22 forks source link

2015-Feb-03 Performance Improvements #16

Closed jmatthiesen closed 9 years ago

jmatthiesen commented 9 years ago

Added some performance improvements to avoid getting into timeout states where the JS editor produces a partial completion list.

Added a recursion depth guard to callComponentFunctions (the initial limit is at 2, which is pretty shallow, but it fixed at least one timeout that was being hit the first time you brought up IntelliSense)
Sprinkled in some calls to intellisense.progress() which hints to the JS editor that long running code is in fact making progress, which provides us some more time to complete execution of the code

Minor refactor to tests:

Consistently changed the casing of // TEST: comments (Just makes it easier to spot them at a quick scan)
Made one of the multi-file tests consistent with the format used in other tests (commenting out a test case)

jmbledsoe commented 9 years ago

This looks good. Thanks for taking the initiative to add this feature.