search

jmbledsoe / angularjs-visualstudio-intellisense

Visual Studio extension providing statement completion for injected AngularJS components in JavaScript files.
MIT License
110 stars 22 forks source link

Adding IntelliSense support for Ionic #31

Open jmatthiesen opened 8 years ago

jmatthiesen commented 8 years ago

I'm planning to make a version of this Angular extension so that it works with Ionic. It should be as simple as:

  1. Creating a copy of angular.intellisense.js and naming it ionic.bundle.intellisense.js
  2. Adding a call to trackModule('ionic'); after the existing trackModule('ng');

However, I don't want to make a full copy of angular.intellisense.js in source control, because we risk not having changes stay in sync between the two files. What do you think of the following design proposal?

Proposal

  1. Refactor common code into an IntelliSenseExtension.js file that has the shared source for both frameworks (this is most of the code).
  2. Create an angular.suffix.js file with the code that is unique to Angular (i.e. trackModule('ng');)
  3. Create an ionic.suffix.js file with the same unique code for Ionic (i.e. trackModule('ionic');)
  4. Use Gulp and a gulpfile.js build script that takes the common code and suffix files and outputs both angular.intellisense.js and ionic.bundle.intellisense.js
  5. Add a dist folder to this repo that contains the build output for anyone that just wants to download and use the built files.
jmbledsoe commented 8 years ago

I am honestly fine with whatever. I haven't been in a position to contribute to this project lately (new job), and I'm not working much with AngularJS anymore, so I don't have strong opinions about it. If you have vision, then run with it.