search

jmboehm / GLFixedEffectModels.jl

Fast estimation of generalized linear models with high dimensional categorical variables in Julia
Other
33 stars 6 forks source link

adapt bias_correction() to the new changes and fix broken tests #31

Closed caibengbu closed 3 years ago

caibengbu commented 3 years ago

This PR changes bias_correction() to adapt to the latest change to nlreg() in 7e0112285ba7a688caab77f9fd245e13004c4e74. Broken tests for bias_correction() are also fixed. We now need to set save = [:eta, :mu] when running nlreg() before bias correction, instead of save = true.

codecov[bot] commented 3 years ago

Codecov Report

Merging #31 (9d47d10) into master (296b523) will increase coverage by 33.26%. The diff coverage is 96.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #31       +/-   ##
===========================================
+ Coverage   46.35%   79.62%   +33.26%     
===========================================
  Files          13       13               
  Lines         906      898        -8     
===========================================
+ Hits          420      715      +295     
+ Misses        486      183      -303
Impacted Files Coverage Δ
src/utils/biascorr.jl 79.42% <96.77%> (+79.42%) :arrow_up:
src/fit.jl 81.19% <0.00%> (+1.83%) :arrow_up:
src/utils/formula.jl 72.13% <0.00%> (+22.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 296b523...9d47d10. Read the comment docs.