Closed junder873 closed 1 year ago
Patch coverage: 79.62
% and project coverage change: +2.26
:tada:
Comparison is base (
cf5c96e
) 88.63% compared to head (4b81092
) 90.89%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Great, thank you. I had preferred to not make FixedEffectModels a dependency but only FixedEffects (the former changes more often, and therefore there may be more maintenance required), but I agree that much code is overlapping between the two packages. I'll tag a new release with this.
Currently this package has some conflicting exports with FixedEffectModels.jl. This makes writing functions when both are being used in a single project more difficult. However, the exports directly overlap (GLFixedEffectModels.fe is the same as FixedEffectModels.fe), so it is simpler to reuse the function from FixedEffectModels.
In addition to that change, there are a number of functions in this package that are essentially the same as their counterparts in FixedEffectModels.jl, so in this pull request I tried to simplify this package by referring to those functions where appropriate.
Finally, to address #26, this pull request updates to Vcov.jl. This update proved tricky since some of the defaults do not quite work, so this pull request adds in a specific type (
VcovDataGLM
) and a few changes toStatsAPI.vcov
functions to create the correct residuals.