jmboehm / KeplerGL.jl

Geospatial Visualization in Julia via Kepler.gl
MIT License
2 stars 1 forks source link

split KeplerGLBase #10

Closed hhaensel closed 1 month ago

hhaensel commented 1 month ago

This PR addresses #7 to split off KeplerGLBase.

montyvesselinov commented 1 month ago

I hope this can be merged so we can propose more changes. thank you!

hhaensel commented 1 month ago

It seems that we still need to make a compat entry for KeplerGLBase. Shall I do that here?

jmboehm commented 1 month ago

Ah, yes please. I always forget those...

hhaensel commented 1 month ago

I still need to fix the location of the test map....

hhaensel commented 1 month ago

One question concering tests. Shall we keep the tests in KeplerGL? Everything has been tested in KeplerGLBase.

We could keep a minimal test, like exporting where Blink is needed. What do you think?

hhaensel commented 1 month ago

Hm, probably difficult without a mapbox token...

jmboehm commented 1 month ago

Ideally we'd keep stuff that requires the frontend in the tests, such as the png export. I've provided a mapbox token as secret that we can use (as long as it doesn't run too often!). If you add the following line to an "env" in ci.yml, I think you should be able to access MAPBOX_KEY as an environment variable. 🤞

MAPBOX_KEY: ${{ secrets.MAPBOX_KEY }}
jmboehm commented 1 month ago

Alright, I'm not sure why this doesn't work, but I'll merge this and will try to sort out the mapbox token issue in the next few days. Thanks a lot for the PR.

hhaensel commented 1 month ago

Maybe I'm doing something wrong with the MAPBOX_KEY. @jmboehm could you review, please?

hhaensel commented 1 month ago

@jmboehm Most probably the secret must simply be shifted some lines up ... EDIT: together with a new env: section