Closed hhaensel closed 1 month ago
I hope this can be merged so we can propose more changes. thank you!
It seems that we still need to make a compat entry for KeplerGLBase. Shall I do that here?
Ah, yes please. I always forget those...
I still need to fix the location of the test map....
One question concering tests. Shall we keep the tests in KeplerGL? Everything has been tested in KeplerGLBase.
We could keep a minimal test, like exporting where Blink is needed. What do you think?
Hm, probably difficult without a mapbox token...
Ideally we'd keep stuff that requires the frontend in the tests, such as the png export. I've provided a mapbox token as secret that we can use (as long as it doesn't run too often!). If you add the following line to an "env" in ci.yml
, I think you should be able to access MAPBOX_KEY as an environment variable. 🤞
MAPBOX_KEY: ${{ secrets.MAPBOX_KEY }}
Alright, I'm not sure why this doesn't work, but I'll merge this and will try to sort out the mapbox token issue in the next few days. Thanks a lot for the PR.
Maybe I'm doing something wrong with the MAPBOX_KEY. @jmboehm could you review, please?
@jmboehm
Most probably the secret must simply be shifted some lines up ...
EDIT: together with a new env:
section
This PR addresses #7 to split off KeplerGLBase.