search

jmboehm / KeplerGL.jl

Geospatial Visualization in Julia via Kepler.gl
MIT License
2 stars 1 forks source link

Possibility to provide custom "data layer" names?! #8

Open montyvesselinov opened 1 month ago

montyvesselinov commented 1 month ago

Would it be ok to allow for custom "data layer" names? At the moment, all the dataset_id include "datalayer" by default. If you want I can develop a PR to address this. Thank you!

jmboehm commented 1 month ago

Yes, of course, please go ahead with creating a PR.

montyvesselinov commented 1 month ago

Are you going to make KeplerGLBase a dependency of KeplerGL?

Many functionality are repeated in both repo's. I think it will be easier if you use KeplerGLBase.jl in KeplerGL.jl.

Other wise I need to submit 2 PR's.

Thank you!

https://envitrace.com/

Velimir “monty” Vesselinov

Co-Founder & CTO - Envitrace

+1 505-473-4150

@.***> https://calendly.com/montyv https://github.com/montyvesselinov https://www.linkedin.com/in/montyvesselinov https://montyv.github.io/

On Sun, Apr 28, 2024 at 6:01 PM Johannes Boehm @.***> wrote:

Yes, of course, please go ahead with creating a PR.

— Reply to this email directly, view it on GitHub https://github.com/jmboehm/KeplerGL.jl/issues/8#issuecomment-2081688707, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK7C6FGBNP7TXIMQ4UWZ2LY7V5UTAVCNFSM6AAAAABG5GVTEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGY4DQNZQG4 . You are receiving this because you authored the thread.Message ID: @.***>

jmboehm commented 1 month ago

Are you going to make KeplerGLBase a dependency of KeplerGL?

That's what #7 asked for, although I don't know whether that's still the plan. @hhaensel do you still plan on separating KeplerGLBase from the display code? No problem if not, but then I'll delete KeplerGLBase.jl to avoid confusion.

hhaensel commented 1 month ago

I'm still interested in doing that but I had too many other hot spots. I hope I can work on that this week.

hhaensel commented 1 month ago

Just submitted two PRs ...

montyvesselinov commented 1 month ago

Thank you!

https://envitrace.com/

Velimir “monty” Vesselinov

Co-Founder & CTO - Envitrace

+1 505-473-4150

@.***> https://calendly.com/montyv https://github.com/montyvesselinov https://www.linkedin.com/in/montyvesselinov https://montyv.github.io/

On Wed, May 1, 2024 at 3:56 AM hhaensel @.***> wrote:

Just submitted two PRs ...

— Reply to this email directly, view it on GitHub https://github.com/jmboehm/KeplerGL.jl/issues/8#issuecomment-2088175404, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK7C6BZFG7MUIBJHKIMUNTZACU5VAVCNFSM6AAAAABG5GVTEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGE3TKNBQGQ . You are receiving this because you authored the thread.Message ID: @.***>