Analysis on the fit for the hiAPP_clustering notebook - Githubissues

jmborr / idpflex

Analysis of intrinsically disordered proteins by comparing MD simulations to Small Angle Scattering experiments

http://idpflex.readthedocs.io/en/latest/

MIT License

3 stars 4 forks source link

Analysis on the fit for the hiAPP_clustering notebook #48

Closed jmborr closed 6 years ago

jmborr commented 6 years ago

Fixes #46

Code Review

[ ] Is the code of an acceptable quality?
[ ] Does the code conform to the [coding standards]?
[ ] Are the unit tests small and test the class in isolation?
[ ] If there are changes in the release notes then do they describe the changes appropriately?

Functional Tests

[ ] Do changes function as described? Add comments below that describe the tests performed?
[ ] Do the changes handle unexpected situations, e.g. bad input?
[ ] Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @idpflex/gatekeepers will take care of it.