Refactor the incoherent scattering to emulate the coherent scattering calculations - Githubissues

jmborr / nscsim

calculation of neutron scattering functions for powder, amorphous, confined, and liquid materials

MIT License

2 stars 1 forks source link

Refactor the incoherent scattering to emulate the coherent scattering calculations #38

Closed jmborr closed 5 years ago

jmborr commented 5 years ago

Description of work.

[ ] Source
[ ] Unit tests
[ ] Update HISTORY file
[ ] Documentation builds and has been read for typos
[ ] example in notebook

To test:

Fixes #37

Code Review

[ ] Is the code of an acceptable quality?
[ ] Does the code conform to the [coding standards]?
[ ] Are the unit tests small and test the class in isolation?
[ ] If there are changes in HISTORY.rst then do they describe the changes appropriately?

Functional Tests

[ ] Do changes function as described? Add comments below that describe the tests performed?
[ ] Do the changes handle unexpected situations, e.g. bad input?

Documentation

[ ] Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @nscsim/gatekeepers will take care of it.